Skip to content

WIP: #4452 Add message specify_file_by_relative_path#4892

Closed
clarmso wants to merge 5 commits intocypress-io:developfrom
clarmso:issue-4452
Closed

WIP: #4452 Add message specify_file_by_relative_path#4892
clarmso wants to merge 5 commits intocypress-io:developfrom
clarmso:issue-4452

Conversation

@clarmso
Copy link
Copy Markdown
Contributor

@clarmso clarmso commented Aug 1, 2019 •
edited
Loading

Pre-merge Tasks

I've added an error message notifying the user that the "file:///" protocol isn't supported by Cypress. I'm marking this PR as a WIP because

  • The error message can be improved.
  • The documentation to cy.visit() does not specify that the "file:///" protocol isn't supported. I need to add a note to this page.
  • Where should I add the test? I cannot add it to navigation_spec.coffee because of the same origin policy. In other words, I cannot just have a test with a single cy.visit('file:///....') command. The cypress.json file has the baseUrl specified.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane
Copy link
Copy Markdown
Member

jennifer-shehane commented Aug 1, 2019

Thanks for the contribution! Could you please sign our CLA?

@clarmso
Copy link
Copy Markdown
Contributor Author

clarmso commented Aug 1, 2019 •
edited
Loading

@jennifer-shehane Let me tried to fix the github email address. I've signed the CLA using the link provided by CLAassistant's link above. CLA signed!

@clarmso clarmso mentioned this pull request Aug 9, 2019
Merged
@clarmso
Copy link
Copy Markdown
Contributor Author

clarmso commented Aug 14, 2019

Bummer. I merged someone unrelated to my work by mistake. Here's the PR: #4982

@clarmso clarmso closed this Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On cy.visit('file://...) throw err to explain they should visit relative html file

4 participants

@clarmso @CLAassistant @jennifer-shehane @chrisbreiding